[U-Boot] [PATCH 4/4] mpc8323erdb: Update crc32 check of MAC

[Wolfgang Denk]

Dear Tom Rini,

In message <1368477117-32669-4-git-send-email-trini at ti.com> you wrote:
> We need to cast to unsigned char, not unsigned short here to avoid a
> warning.

You fix the warning, but break the code.

> Cc: Michael Barkowski <michael.barkowski at freescale.com>
> Signed-off-by: Tom Rini <trini at ti.com>
> ---
>  board/freescale/mpc8323erdb/mpc8323erdb.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/board/freescale/mpc8323erdb/mpc8323erdb.c b/board/freescale/mpc8323erdb/mpc8323erdb.c
> index f29b2f4..ba4993e 100644
> --- a/board/freescale/mpc8323erdb/mpc8323erdb.c
> +++ b/board/freescale/mpc8323erdb/mpc8323erdb.c
> @@ -195,7 +195,7 @@ int mac_read_from_eeprom(void)
>  		printf("\nEEPROM @ 0x%02x read FAILED!!!\n",
>  		       CONFIG_SYS_I2C_EEPROM_ADDR);
>  	} else {
> -		if (crc32(crc, buf, 24) == *(unsigned int *)&buf[24]) {
> +		if (crc32(crc, buf, 24) == *(unsigned char *)&buf[24]) {

We need to read a 32 bit number here.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Politician:  An  eel  in  the  fundamental   mud   upon   which   the
superstructure  of  organized  society is reared. When he wriggles he
mistakes the agitation of his tail for the trembling of the  edifice.
As  compared with the statesman, he suffers the disadvantage of being
alive.                                               - Ambrose Bierce