[U-Boot] [PATCH v2] powerpc/mpc85xx: The end address of the bss in the SPL should be 4byte alignment

Wolfgang Denk wd at denx.de
Tue May 14 12:30:05 CEST 2013


Dear ying.zhang at freescale.com,

In message <1368520918-22496-1-git-send-email-ying.zhang at freescale.com> you wrote:
> From: Ying Zhang <b40530 at freescale.com>

You mark this patch as V2 but there is no history of changes.  Please
always include information what exactly was changed.

> There will clear the BSS in the function clear_bss(), the reset address of
> the BSS started from the __bss_start, and increased by four-byte increments,
> finally stoped depending on the adress is equal to the _bss_end. If the end
> address __bss_end is not alignment to 4byte, it will be an infinite loop.
> 
> The end address of the bss should be 4byte aligned.

NAK. This is the wrong way to fix this.

Instead, the test in the loop should be fixed to test for "<=".

>  /*
> - * (C) Copyright 2006
> + * (C) Copyright 2013
>   * Wolfgang Denk, DENX Software Engineering, wd at denx.de

And PLEASE do not mess with _my_ copyrights!!!


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
God runs electromagnetics by wave theory on  Monday,  Wednesday,  and
Friday,  and the Devil runs them by quantum theory on Tuesday, Thurs-
day, and Saturday.                                   -- William Bragg


More information about the U-Boot mailing list