[U-Boot] [PATCH v2 4/4] arm: factorize relocate_code routine

[Benoît Thébaudeau]

Hi Albert,

On Tuesday, May 14, 2013 6:32:08 PM, Albert ARIBAUD wrote:
> Hi Benoît,
> 
> On Tue, 14 May 2013 18:01:50 +0200 (CEST), Benoît Thébaudeau
> <benoit.thebaudeau at advansee.com> wrote:
> 
> > Hi Albert,
> 
> > >  	.globl	c_runtime_cpu_setup
> > >  c_runtime_cpu_setup:
> > >  
> > > -	bx	lr
> > > +	/*
> > > +	 * Unlock (actually, disable) the cache now that board_init_f
> > > +	 * is done. We could do this earlier but we would need to add
> > > +	 * a new C runtime hook, whereas c_runtime_cpu_setup already
> > > +	 * exists.
> > > +	 * As this routine is just a call to cpu_init_crit, let us
> > > +	 * tail-optimize and do a simple branch here.
> > > +	 */
> > > +	b	cpu_init_crit
> > 
> > Shouldn't the "#ifdef CONFIG_CPU_PXA25X" from the original code be kept
> > here?
> 
> Yes, it should indeed. Thanks for spotting this!

Have you seen the end of my notes for relocate.S? After all, keeping for later
your patches moving to compiler-generated symbols seems to complicate things and
to be more error-prone.

Best regards,
Benoît