[U-Boot] [PATCH v2] common/Makefile: Add new symbol CONFIG_SPL_ENV_SUPPORT to replace CONFIG_SPL_NET_SUPPORT
Zhang Ying-B40530
B40530 at freescale.com
Wed May 15 04:06:11 CEST 2013
> > endif
> >
> > ifdef CONFIG_SPL_BUILD
> > -COBJS-y += cmd_nvedit.o
> > -COBJS-y += env_common.o
> > COBJS-$(CONFIG_ENV_IS_IN_FLASH) += env_flash.o
> > COBJS-$(CONFIG_SPL_YMODEM_SUPPORT) += xyzModem.o
> > -COBJS-$(CONFIG_SPL_NET_SUPPORT) += cmd_nvedit.o
> > -COBJS-$(CONFIG_SPL_NET_SUPPORT) += env_attr.o
> > -COBJS-$(CONFIG_SPL_NET_SUPPORT) += env_callback.o
> > -COBJS-$(CONFIG_SPL_NET_SUPPORT) += env_common.o
> > -COBJS-$(CONFIG_SPL_NET_SUPPORT) += env_flags.o
> > -COBJS-$(CONFIG_SPL_NET_SUPPORT) += env_nowhere.o
> > COBJS-$(CONFIG_SPL_NET_SUPPORT) += miiphyutil.o
> > +COBJS-$(CONFIG_SPL_ENV_SUPPORT) += env_common.o
> > +COBJS-$(CONFIG_SPL_ENV_SUPPORT) += env_attr.o
> > +COBJS-$(CONFIG_SPL_ENV_SUPPORT) += env_flags.o
> > +COBJS-$(CONFIG_SPL_ENV_SUPPORT) += env_callback.o
> > endif
> > +COBJS-y += cmd_nvedit.o
> > +COBJS-$(CONFIG_ENV_IS_NOWHERE) += env_nowhere.o
> > COBJS-$(CONFIG_BOUNCE_BUFFER) += bouncebuf.o
> > COBJS-y += console.o
> > COBJS-y += dlmalloc.o
>
> Just move the whole CONFIG_ENV_IS_IN.. section down to where we always
> build objects, and update the comments in the Makefile in both spots.
> [Zhang Ying]
> For common lines(for example: cmd_nvedit.o) that shared by the SPL and non-SPL,
> can we move it to public area? So, we can avoid excessive SPL symbols.
Right. Re-order things so we're duplicating as little as possible.
There's already a bit of needless duplication going on here.
[Zhang Ying]
Ok, we had moved CONFIG_ENV_IS_IN.. section to public area in another patch just
submitted :"move the common makefile line out of the CONFIG_SPL_BUILD ifdef".
Please review.
More information about the U-Boot
mailing list