[U-Boot] [PATCH v2 1/6] arm: mvf600: Add Vybrid MVF600 CPU support

[Stefano Babic]

On 15/05/2013 14:09, Albert ARIBAUD wrote:
>>
>> Albert, what do you think about ? Should these files be moved away from
>> armv7 ?
> 
> If the SoC is ARMv5, then yes, its arch/arm/cpu files should not go in
> armv7 -- and then, we may have to discuss whether, and how, to factorize
> ISA-level code. Maybe we need an arch/arm/isa/armv{4,5,6,7...} beside
> arch/cpu, and move wherever is isa-specific there.

Agree. I think adding armv{4,5,6,7...} is the most clean solution.

> 
> Regarding errata, I don't understand your point: if they are specific
> to armv7, then arch/arm/cpu/armv7/start.S seems to be the place to put
> them (assuming they affect execution before board_init_f() of course).

I was not able to express my point, sorry. Of course, the right place
for them is arch/arm/cpu/armv7/start.S. My concern was related to this
SOC, as it seems it steals armv7 code but it is not armv7. Then changes
in start.S, that fixes real problems for armv7, can break this Vybrid.
But the reason is that Vybrid initialization should not be taken from
arch/arm/cpu/armv7/start.S.

Best regards,
Stefano

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================