[U-Boot] [PATCH 1/3 V5] EXYNOS5: Add gpio pin numbering feature

[Simon Glass]

Hi Minkyu,

On Sun, May 12, 2013 at 9:07 PM, Rajeshwari Birje
<rajeshwari.birje at gmail.com> wrote:
> Hi Simon,
>
> I applied the V5 patches on the latest u-boot-samsung tree and need
> seem to compile fine.
> Yes I will need to rebase them once the MMC patches get in, but will
> wait for comments from Minkyu Kang as well
> so that I can incorporate them and rebase the patch set once the MMC
> patches get in.

I am looking forward to seeing the outstanding patches applied - will
this be soon?

Regards,
Simon

>
> Regards,
> Rajeshwari Shinde.
>
> On Sat, May 11, 2013 at 11:48 PM, Simon Glass <sjg at chromium.org> wrote:
>> HI Rajeshwari,
>>
>> On Wed, Apr 3, 2013 at 5:54 AM, Rajeshwari Shinde
>> <rajeshwari.s at samsung.com> wrote:
>>> This patch adds support for gpio pin numbering support on
>>> EXYNOS5250
>>> To have consistent 0..n-1 GPIO numbering the banks are divided
>>> into different parts where ever they have holes in them.
>>>
>>> Signed-off-by: Leela Krishna Amudala <l.krishna at samsung.com>
>>> Signed-off-by: Rajeshwari Shinde <rajeshwari.s at samsung.com>
>>> ---
>>> Changes in V2:
>>>         - none.
>>> Changes in V3:
>>>         - none.
>>> Changes in V4:
>>>         - To have consistent 0..n-1 GPIO numbering the banks are divided
>>>         into different parts where ever they have holes in them.
>>>         - Combined previous patch 1 and 2 into single patch.
>>> Changes in V5:
>>>         - Removed Exynos5 specific code in gpio driver api to
>>>         get bank.
>>>         - Added #define HAVE_GENERIC_GPIO in config file
>>>         to remove conditinal CPU check in gpio driver.
>>
>> With this series I am getting errors in exynos5-dt.c:
>>
>> 25: EXYNOS5: Add gpio pin numbering feature
>>        arm: +   snow
>> +exynos5-dt.c: In function 'board_usb_vbus_init':
>> +exynos5-dt.c:79: error: 'struct exynos5_gpio_part1' has no member named 'x2'
>> +exynos5-dt.c: In function 'board_enable_audio_codec':
>> +exynos5-dt.c:95: error: 'struct exynos5_gpio_part1' has no member named 'x1'
>> +exynos5-dt.c:96: error: 'struct exynos5_gpio_part1' has no member named 'x1'
>> +exynos5-dt.c: In function 'exynos_cfg_lcd_gpio':
>> +exynos5-dt.c:412: error: 'struct exynos5_gpio_part1' has no member named 'x1'
>> +exynos5-dt.c:413: error: 'struct exynos5_gpio_part1' has no member named 'x1'
>> +exynos5-dt.c:416: error: 'struct exynos5_gpio_part1' has no member named 'x0'
>>
>>
>> This is probably due to new support added, so I think you need to
>> adjust your patch.
>>
>> Here is the sequence I am testing with (reverse order of application):
>>
>> 9529fd4 (HEAD, ws/snow, snow) EXYNOS5: GPIO: Enable GPIO Command for EXYNOS5
>> 0f81b33 S5P: Rename GPIO definitions
>> 0c6254b EXYNOS5: Add gpio pin numbering feature
>> 5a35ef9 CONFIG: EXYNOS5: Enable silent console
>> 6083f4f S5P: Serial: Add fdt support to driver
>> 2f78e0f EXYNOS5: FDT: Add serial device node values
>> 5b85902 EXYNOS5: FDT: Add compatible strings for Serial
>> 6402856 exynos: dts: Use 50MHz SPI flash speed on snow
>> 1a6900e EXYNOS: SPL: Add a custom spi copy function
>> 27530a7 EXYNOS: SPI: Support word transfers
>> 7f8ba96 EXYNOS: SPI: Minimise access to SPI FIFO level
>> 149742a EXYNOS: SPI: Support a delay after deactivate
>> f3d8caf EXYNOS: Export timer_get_us() to get microsecond timer
>> 1aaa266 EXYNOS: SPI: Support SPI_PREAMBLE mode
>> 2752d08 SPI: Add support for preamble bytes
>> 279a5cb exynos: Enable mmc for snow
>> a6280ba COMMON: MMC: Command to support EMMC booting and to resize
>> EMMC boot partition
>> 19425ea SMDK5250: Enable EMMC booting
>> 5253ae0 MMC: APIs to support resize of EMMC boot partition
>> 15bb05e SMDK5250: Initialise and Enable DWMMC, support FDT and non-FDT
>> eeef540 EXYNOS5: DWMMC: Initialise the local variable to avoid unwanted results.
>> a4d8bf2 EXYNOS5: DWMMC: Added FDT support for DWMMC
>> 71b87c4 DWMMC: Initialise dwmci and resolve EMMC read write issues
>> 97c6565 EXYNOS5: FDT: Add DWMMC device node data
>> ec5fb8b FDT: Add compatible string for DWMMC
>> e7c528b EXYNOS5: I2C: Add FDT and non-FDT support for I2C
>>
>> Regards,
>> Simon
>>
>>
>>>  arch/arm/cpu/armv7/exynos/pinmux.c      |  150 ++++------
>>>  arch/arm/include/asm/arch-exynos/cpu.h  |   10 +-
>>>  arch/arm/include/asm/arch-exynos/gpio.h |  452 +++++++++++++++++++++++++++----
>>>  board/samsung/smdk5250/smdk5250.c       |   24 +-
>>>  drivers/gpio/s5p_gpio.c                 |   42 +++
>>>  include/configs/exynos5250-dt.h         |    1 +
>>>  6 files changed, 522 insertions(+), 157 deletions(-)
>>>
>> _______________________________________________
>> U-Boot mailing list
>> U-Boot at lists.denx.de
>> http://lists.denx.de/mailman/listinfo/u-boot
>
>
>
> --
> Regards,
> Rajeshwari Shinde