[U-Boot] [PATCH v5] Add support for Congatec Conga-QEVAl board

[SARTRE Leo]

On Thursday 16 May 2013 17:09:35, Stefano Babic wrote :

Hi Stefano,

> > +#define UART_PAD_CTRL  (PAD_CTL_PKE | PAD_CTL_PUE |\
> > +	PAD_CTL_PUS_100K_UP | PAD_CTL_SPEED_MED |\
> > +	PAD_CTL_DSE_40ohm   | PAD_CTL_SRE_FAST  | PAD_CTL_HYS)
> > +
> 
> commit 7e2173cf82d0bc235b695460c56d46927febdf36 makes PUE to set
> automatically PKE. Board files have to set only the required value for
> pullup. In your case, you need to put in the mask only
> PAD_CTL_PUS_100K_UP, dropping PAD_CTL_PKE | PAD_CTL_PUE.
> 
> > +#define USDHC_PAD_CTRL (PAD_CTL_PKE | PAD_CTL_PUE |\
> > +	PAD_CTL_PUS_47K_UP  | PAD_CTL_SPEED_LOW |\
> > +	PAD_CTL_DSE_80ohm   | PAD_CTL_SRE_FAST  | PAD_CTL_HYS)
> 
> Ditto.
> 

Ok I will drop PAD_CTL_PKE | PAD_CTL_PUE.

> > +int checkboard(void)
> > +{
> > +#ifdef CONFIG_MX6Q
> > +	puts("Board: Conga-QEVAL QMX6 Quad\n");
> > +#endif
> 
> Is there also a DL version ? If not, you could drop the #ifdef
> 

Yes there is a DL version but I do not have the module so I cannot test it.

Thanks for your advices.

Regards,

--
Leo