[U-Boot] [PATCH v3 4/4] arm: factorize relocate_code routine

Albert ARIBAUD albert.u.boot at aribaud.net
Thu May 16 18:57:19 CEST 2013


Hi Benoît,

On Thu, 16 May 2013 17:56:29 +0200 (CEST), Benoît Thébaudeau
<benoit.thebaudeau at advansee.com> wrote:

> Hi Albert,

> Keeping an empty line here would be good for code clarity.

> Or "&_start" in the comment above to be more consistent with the comments below.

> It's __rel_dyn_start and __rel_dyn_end with 2 leading underscores in the 4
> comments above.

Will fix all three, thanks.

> Argh! The "bx lr" issue is back. That was correct in v2.

As you say: argh! Will fix, and apologies.

> The rest of the v3 series is fine.

Thanks for your review!

> Best regards,
> Benoît

Amicalement,
-- 
Albert.


More information about the U-Boot mailing list