[U-Boot] [PATCH v2] spl: Make CONFIG_SPL_BUILD contain more functionality

[Tom Rini]

On Fri, May 17, 2013 at 05:12:19PM +0800, ying.zhang at freescale.com wrote:

> From: Ying Zhang <b40530 at freescale.com>
> 
> There was some functionality will be used in the SPL. They
> had been excluded by ifndef CONFIG_SPL_BUILD. Now, put it
> into the SPL.
> 
> Signed-off-by: Ying Zhang <b40530 at freescale.com>
> ---
> Compared with the previous version, give up new symbol and delete the line
> ifndef CONFIG_SPL_BUILD in common/env_common.c

What the heck is going on?  First, you seem to be changing a number of
checks from !CONFIG_SPL_BUILD to !CONFIG_SPL_NAND_MINIMAL, and then stop
defining CONFIG_SPL_NAND_MINIMAL always and only define it for
CONFIG_SPL_BUILD.  Next, powerpc uses
-ffunction-sections/-fdata-sections/--gc-sections so outside of
assembler files, we shouldn't need to be using CONFIG_SPL_BUILD to not
build something that's a static function.

Can you please post the everything as a series, including adding the
board(s) that need environment in SPL?

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130517/dc390111/attachment.pgp>