[U-Boot] [PATCH 1/9] wandboard: Return error if the SDHC port index is invalid

Otavio Salvador otavio at ossystems.com.br
Tue May 21 20:44:41 CEST 2013


On Tue, May 21, 2013 at 3:39 PM, Fabio Estevam <festevam at gmail.com> wrote:

> On Tue, May 21, 2013 at 3:26 PM, Otavio Salvador
> <otavio at ossystems.com.br> wrote:
>
> > When I looked at this code I didn't change it because it raises a
> warning.
> > So it returns the status if any failed.
>
> Which warning are you talking about? Build warning or run-time warning?
>
> I did not see any of these here.
>
> status is zero at that point of code, so we should not 'return 0' on
> failure.
>

In the loop; it does:

status |= fsl...

so it gets the output of it. In case any fails it won't be 0.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://projetos.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750


More information about the U-Boot mailing list