[U-Boot] [PATCH 1/9] wandboard: Return error if the SDHC port index is invalid

Otavio Salvador otavio at ossystems.com.br
Tue May 21 21:00:43 CEST 2013


On Tue, May 21, 2013 at 3:49 PM, Fabio Estevam <festevam at gmail.com> wrote:

> On Tue, May 21, 2013 at 3:44 PM, Otavio Salvador
> <otavio at ossystems.com.br> wrote:
>
> > In the loop; it does:
> >
> > status |= fsl...
> >
> > so it gets the output of it. In case any fails it won't be 0.
>
> It's good practice to return immediately when an error condition happens.
>

Well the idea of the code was to return in case anything goes wrong. So it
outputs a 'WARN'. If you wish to change this, please change to ERROR.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://projetos.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750


More information about the U-Boot mailing list