[U-Boot] [PATCH] common/Makefile: Add new symbol CONFIG_SPL_ENV_SUPPORT for environment in SPL

[Zhang Ying-B40530]

-----Original Message-----
From: Tom Rini [mailto:tom.rini at gmail.com] On Behalf Of Tom Rini
Sent: Thursday, May 23, 2013 5:23 AM
To: Zhang Ying-B40530
Cc: Stefan Roese; Wood Scott-B07421; Xie at theia.denx.de; afleming at gmail.com; u-boot at lists.denx.de
Subject: Re: [U-Boot] [PATCH] common/Makefile: Add new symbol CONFIG_SPL_ENV_SUPPORT for environment in SPL

On Wed, May 22, 2013 at 08:06:01AM +0000, Zhang Ying-B40530 wrote:
> 
> 
> -----Original Message-----
> From: Stefan Roese [mailto:sr at denx.de] 
> Sent: Wednesday, May 22, 2013 2:09 PM
> To: Wood Scott-B07421
> Cc: Zhang Ying-B40530; Wood Scott-B07421; Xie at theia.denx.de; u-boot at lists.denx.de; afleming at gmail.com
> Subject: Re: [U-Boot] [PATCH] common/Makefile: Add new symbol CONFIG_SPL_ENV_SUPPORT for environment in SPL
> 
> (sorry for jumping in so late in this discussion)
> 
> On 05/21/2013 09:14 PM, Scott Wood wrote:
> >> This is Tom's words:
> >>
> >> a3m071 relies on SPL always building cmd_nvedit.o and env_common.o and
> >> duplicated CONFIG_ENV_IS_IN_FLASH in the SPL section.
> >>
> >> CONFIG_SPL_NET_SUPPORT relies on the same always-built ins and adds
> >> env_nowhere.o which works because the regular CONFIG_ENV_IS_IN_...
> >>
> >> section is in the non-SPL-only area.
> > 
> > If "SPL: Makefile: Build a separate autoconf.mk for SPL" gets merged,  
> > we could just have a3m071 define CONFIG_ENV_IS_NOWHERE in the SPL build  
> > case.
> 
> But the a3m071 SPL U-Boot version also uses the env from NOR flash. So
> defining CONFIG_ENV_IS_NOWHERE here would be really confusing!
> [Zhang Ying] 
> I think Scott means that the specific boards CONFIG_SPL_NET_SUPPORT
> is set should define CONFIG_ENV_IS_NOWHERE in the SPL build case. For 
> example: am335x and pcm051.

Correct.  I need to see if I can reproduce the problem I had with Joel's
patch however.
[Zhang Ying] 
So, Can you accept this patch now? I hope to finish it early, have spent a long time.