[U-Boot] FW: [PATCH 5/6] spl: Make CONFIG_SPL_BUILD contain more functionality

[Zhang Ying-B40530]

-----Original Message-----
From: Wood Scott-B07421 
Sent: Wednesday, May 22, 2013 3:42 AM
To: Zhang Ying-B40530
Cc: u-boot at lists.denx.de; afleming at gmail.com; Xie Xiaobo-R63061; Zhang Ying-B40530; Ilya Yanok
Subject: Re: [PATCH 5/6] spl: Make CONFIG_SPL_BUILD contain more functionality

Please change the title and the rest of the changelog to describe what  
functionality you're adding and why.

On 05/20/2013 01:07:27 AM, ying.zhang at freescale.com wrote:
> diff --git a/common/env_common.c b/common/env_common.c
> index 906b41f..8cb81e9 100644
> --- a/common/env_common.c
> +++ b/common/env_common.c
> @@ -156,7 +156,6 @@ int set_default_vars(int nvars, char * const  
> vars[])
>  				H_NOCLEAR | H_INTERACTIVE, nvars, vars);
>  }
> 
> -#ifndef CONFIG_SPL_BUILD
>  /*
>   * Check if CRC is valid and (if yes) import the environment.
>   * Note that "buf" may or may not be aligned.
> @@ -188,7 +187,6 @@ int env_import(const char *buf, int check)
> 
>  	return 0;
>  }
> -#endif

This ifndef was introduced by Ilya Yanok in commit  
7ac2fe2da21d292aeaf3af74e5c80de9ce9dab56.

Ilya, what are the consequences of removing this?  Is there some other  
symbol we can use here?

-Scott
[Zhang Ying] 
Ilya, Can you answer this question? Thanks.