[U-Boot] [PATCH 2/7] ahci: fix unaligned access

Wolfgang Denk wd at denx.de
Fri May 24 20:35:46 CEST 2013


Dear Rob Herring,

In message <1369176276-1895-2-git-send-email-robherring2 at gmail.com> you wrote:
> 
> gcc 4.7 will generate unaligned accesses to local char arrays, so make
> them static to avoid that.
> 
> Signed-off-by: Rob Herring <rob.herring at calxeda.com>
> ---
>  drivers/block/ahci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/block/ahci.c b/drivers/block/ahci.c
> index b89be06..3cb37e7 100644
> --- a/drivers/block/ahci.c
> +++ b/drivers/block/ahci.c
> @@ -627,7 +627,7 @@ static void dump_ataid(hd_driveid_t *ataid)
>   */
>  static int ata_scsiop_inquiry(ccb *pccb)
>  {
> -	u8 hdr[] = {
> +	static u8 hdr[] = {
>  		0,
>  		0,
>  		0x5,		/* claim SPC-3 version compatibility */

Make it also "const" ?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Pull the wool over your own eyes!"                - J.R. "Bob" Dobbs


More information about the U-Boot mailing list