[U-Boot] [PATCH] mmc: fsl_esdhc: Fix hang after 'save' command

Fleming Andy-AFLEMING afleming at freescale.com
Tue May 28 21:51:58 CEST 2013


On May 28, 2013, at 1:09 PM, Fabio Estevam wrote:

> Since commit 48e0b2bd (powerpc/esdhc: Correct judgement for DATA PIO mode) 
> we see mx6 systems to hang after doing a 'save' command.
> 
> Revert this commit since the original 'ifdef' logic from 7b43db92 
> (drivers/mmc/fsl_esdhc.c: fix compiler warnings) was the correct one.
> 
> Reported-by: Tapani Utriainen <tapani at technexion.com>
> Signed-off-by: Fabio Estevam <fabio.estevam at freescale.com>


My apologies. I misread that patch. I found it hard to believe that Wolfgang had broken the logic, and that it had been broken for 2 years, but somehow my brain insisted that was the case. I now agree with your assessment, and will apply your patch.

Haijun, please investigate the problem you were trying to solve with this patch, and determine what the actual cause was, and then submit a new patch to fix it.


Andy


More information about the U-Boot mailing list