[U-Boot] [PATCH 09/12] mmc: omap_hsmmc: add mmc1 pbias, ldo1

[Tom Rini]

On Wed, May 29, 2013 at 04:32:44PM +0530, Lokesh Vutla wrote:
> From: Balaji T K <balajitk at ti.com>
> 
> add dra mmc pbias support and ldo1 power on
> 
> Signed-off-by: Balaji T K <balajitk at ti.com>
> Signed-off-by: Lokesh Vutla <lokeshvutla at ti.com>
[snip]
> +	udelay(150); /* wait 10 us */
> +	value |= SDCARD_PWRDNZ;
> +	writel(value, (*ctrl)->control_pbias);
> +	udelay(150); /* wait 10 us */

That's not 10us.

> +	val = 0x2b; /* (3 -.9)*20 +1 */

Consistent spacing in the math please (and leading 0).

> +	if (palmas_i2c_write_u8(0x58, LDO1_CTRL, val)) {

No magic values please.

Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130529/1fa9bcfe/attachment.pgp>