[U-Boot] [PATCH v4 2/7] arm: vf610: Add Vybrid VF610 CPU support

[Benoît Thébaudeau]

Hi Alison,

On Wednesday, May 29, 2013 7:37:32 AM, Wang Huan-B18965 wrote:
> Hi, Benoit,
> 
> > > > diff --git a/doc/README.vf610 b/doc/README.vf610 new file mode
> > > > 100644 index 0000000..38cf5cf
> > > > --- /dev/null
> > > > +++ b/doc/README.vf610
> > > > @@ -0,0 +1,10 @@
> > > > +U-Boot for Freescale Vybrid VF610
> > > > +
> > > > +This file contains information for the port of U-Boot to the
> > > > +Freescale
> > > > Vybrid
> > > > +VF610 SoC.
> > > > +
> > > > +1. CONVENTIONS FOR FUSE ASSIGNMENTS
> > > > +-----------------------------------
> > > > +
> > > > +1.1 MAC Address: It is stored in fuse bank 4, with the 16 msbs in
> > > > +word 2
> > > > and
> > > > the
> > > > +    32 lsbs in word 3.
> > >
> > > The hunk below is still missing:
> > >
> > > doc/README.mxc_ocotp:
> > > ---
> > >  on MXC
> > >
> > >  This IP can be found on the following SoCs:
> > > + - Vybrid VF610,
> > >   - i.MX6.
> > >
> > >  Note that this IP is different from albeit similar to the IPs of the
> > > same  name
> > > ---
> > 
> > I have just noticed that this was actually in 6/7. Why are you putting
> > this into a separate patch?
> [Alison Wang] Because patch 2/7 is about VF610 CPU support, and
> doc/README.vf610 is also a document about
> VF610 SoC. Doc/README.mxc_ocotp is the document about a driver (IP OCOTP), so
> this driver document should be
> separated from CPU patch 2/7.

I don't think so: It's part of what comes with the addition of the VF610
platform, so 6/7 could be merged into 2/7. But it does not really matter. It's
probably also fine if you keep what you did.

Stefano, any opinion?

Best regards,
Benoît

--------------------------------------------------------------------------------