[U-Boot] [RFC PATCH 5/7] Adjust Kconfig scripts for use by U-Boot

[Tom Rini]

On Fri, May 31, 2013 at 07:01:01PM +0900, Masahiro Yamada wrote:
> Hi, Tom.
> 
> 
> > We would probably want to change it to something like:
> > - Do you want the standard baud rate table?
> >   Yes: 9600/19200/38400/57600/115200
> >   No: Prompt for string value of comma sep list of rates
> > 
> > And in the right header:
> > #ifdef CONFIG_SYS_STD_BAUD_RATE
> > #define BAUDRATTE_TABLE { 9600, .... }
> > #else
> > #define BAUDRATE_TABLE { CONFIG_SYS_PROMPTED_VALUE }
> > #endif
> 
> Could you explain a little further?
> 
> According to Documentation/kbuild/kconfig-languate.txt,
> Kconfig treats "bool"/"tristate"/"string"/"hex"/"int" types.
> Which type can we use for CONFIG_SYS_PROMPTED_VALUE?
[snip]
> And I got include/generated/autoconf.h as follows:
> 
> #define CONFIG_SYS_PROMPTED_VALUE "19200,38400,115200"

Ah, damn.  I was thinking string, but that won't work as you've shown
(thanks!).  Perhaps the best answer is we can do a choice of std table,
full table, 115200, 230400, 9600 and any other single values people
really need.

> > > And also, some config files still include macros without CONFIG_ prefix.
> > > For example, LINUX_BOOT_PARAM_ADDR, PHYS_SDRAM_1, PHYS_SDRAM_2, etc.
> > 
> > These don't belong in the config file, and need to be either in the
> > board or <asm/arch/> or similar construct instead.
> 
> I see.
> 
> Actually, some include/configs/*.h  files still include them,
> so we need to move them to somewhere else, or add prefix
> like CONFIG_LINUX_BOOT_PARAM_ADDR.

There's certainly some header cleanup that needs to happen before a full
transition can happen.  In TI-land there's lots of dependencies on
headers being in the config, only a few of which are needed, and require
real thought (things like CONFIG_SYS_SDRAM_BASE,
CONFIG_SYS_INIT_SP_ADDR).

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130531/587f223c/attachment.pgp>