[U-Boot] [PATCH v1 3/4] i.MX6: add enable_spi_clk()

Fabio Estevam festevam at gmail.com
Fri Jul 11 15:22:30 CEST 2014


Hi Heiko,

On Wed, May 28, 2014 at 7:16 AM, Heiko Schocher <hs at denx.de> wrote:

> --- a/arch/arm/include/asm/arch-mx6/clock.h
> +++ b/arch/arm/include/asm/arch-mx6/clock.h
> @@ -57,6 +57,7 @@ void enable_usboh3_clk(unsigned char enable);
>  int enable_sata_clock(void);
>  int enable_pcie_clock(void);
>  int enable_i2c_clk(unsigned char enable, unsigned i2c_num);
> +int enable_spi_clk(unsigned char enable, unsigned spi_num);
>  void enable_ipu_clock(void);
>  int enable_fec_anatop_clock(enum enet_freq freq);

Apart from comments that Stefano pointed out, the patch looks good.

However, this approach doesn't scale very well. In the future, we
should be looking into adding Common Clock Framework into U-boot, so
that we can better control the clocks like we do in the kernel.

Not sure if there is anyone interested or willing to work on this topic though.

Regards,

Fabio Estevam


More information about the U-Boot mailing list