[U-Boot] [PATCH v1 3/4] i.MX6: add enable_spi_clk()

[Stefano Babic]

Hi Fabio,

On 11/07/2014 15:22, Fabio Estevam wrote:
> Hi Heiko,
> 
> On Wed, May 28, 2014 at 7:16 AM, Heiko Schocher <hs at denx.de> wrote:
> 
>> --- a/arch/arm/include/asm/arch-mx6/clock.h
>> +++ b/arch/arm/include/asm/arch-mx6/clock.h
>> @@ -57,6 +57,7 @@ void enable_usboh3_clk(unsigned char enable);
>>  int enable_sata_clock(void);
>>  int enable_pcie_clock(void);
>>  int enable_i2c_clk(unsigned char enable, unsigned i2c_num);
>> +int enable_spi_clk(unsigned char enable, unsigned spi_num);
>>  void enable_ipu_clock(void);
>>  int enable_fec_anatop_clock(enum enet_freq freq);
> 
> Apart from comments that Stefano pointed out, the patch looks good.
> 
> However, this approach doesn't scale very well. In the future, we
> should be looking into adding Common Clock Framework into U-boot, so
> that we can better control the clocks like we do in the kernel.
> 

I fully agree.

> Not sure if there is anyone interested or willing to work on this topic though.

Anyway, it is good to see this issue because it shows the right way to
follow, even if there is not (yet) anybody ready to implement it.

Regards,
Stefano


-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================