[U-Boot] [PATCH v2 8/9] dm: exynos: Move serial to driver model

Tom Rini trini at ti.com
Mon Jul 28 20:05:12 CEST 2014


On Sun, Jul 13, 2014 at 12:27:41PM -0600, Simon Glass wrote:

> Change the Exynos serial driver to work with driver model and switch over
> all Exynos5 boards to use it.
> 
> Signed-off-by: Simon Glass <sjg at chromium.org>

So, maybe it's just the way the diff was generated, but did you re-order
the functions in the file?  Trying to see for example how 'set_brg'
changed here isn't easy since it used to be at the top, but is now near
the bottom?  And other functions too perhaps.

IOW, assuming the function locations changed in the driver, can you
re-shuffle things so the function order is the same?  This will help
both with review and future conversions I think.  Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140728/eb8da35a/attachment.pgp>


More information about the U-Boot mailing list