[U-Boot] [PATCH v2 8/9] dm: exynos: Move serial to driver model

[Simon Glass]

Hi Tom,

On 28 July 2014 19:05, Tom Rini <trini at ti.com> wrote:
> On Sun, Jul 13, 2014 at 12:27:41PM -0600, Simon Glass wrote:
>
>> Change the Exynos serial driver to work with driver model and switch over
>> all Exynos5 boards to use it.
>>
>> Signed-off-by: Simon Glass <sjg at chromium.org>
>
> So, maybe it's just the way the diff was generated, but did you re-order
> the functions in the file?  Trying to see for example how 'set_brg'
> changed here isn't easy since it used to be at the top, but is now near
> the bottom?  And other functions too perhaps.
>
> IOW, assuming the function locations changed in the driver, can you
> re-shuffle things so the function order is the same?  This will help
> both with review and future conversions I think.  Thanks!

Yes I think i can improve it as you say.

But however you look at it this is essentially a rewrite. All the old
boilerplate for multi-serial is gone (DECLARE_S5P_SERIAL_FUNCTIONS and
so on). The new driver model structures are added. All the functions
change signature and quite a bit of contents. The old driver was 300
lines, the new one is 190.

Unfortunately I think this is going to be a complete pain to review
whatever I do. For the driver model conversion the serial drivers are
all going to be quite different if they currently support multi-serial
using the #define work-around.

Regards,
Simon