[U-Boot] [PATCH 03/12] mtd: nand: s3c: Fix data type width in debug()

Scott Wood scottwood at freescale.com
Tue Jul 29 02:12:47 CEST 2014


On Tue, 2014-07-29 at 02:09 +0200, Marek Vasut wrote:
> On Tuesday, July 29, 2014 at 01:35:57 AM, Scott Wood wrote:
> > On Tue, 2014-07-22 at 02:34 +0200, Marek Vasut wrote:
> > > Printing u32 with %02x is just a bad idea, fix it.
> > 
> > Why is it "just a bad idea" if the values aren't expected to exceed
> > 0xff?
> 
> NAND_CMD_DEPLETE1 is 0x100 for example. I doubt anyone will use AND with this 
> controller, but I'd be much happier to see the print properly matching the 
> variable we're printing.

It will match it.  %02x doesn't restrict the output to two characters;
it just makes sure there are at least two characters.

-Scott




More information about the U-Boot mailing list