[U-Boot] [PATCH 03/12] mtd: nand: s3c: Fix data type width in debug()

[Marek Vasut]

On Tuesday, July 29, 2014 at 02:12:47 AM, Scott Wood wrote:
> On Tue, 2014-07-29 at 02:09 +0200, Marek Vasut wrote:
> > On Tuesday, July 29, 2014 at 01:35:57 AM, Scott Wood wrote:
> > > On Tue, 2014-07-22 at 02:34 +0200, Marek Vasut wrote:
> > > > Printing u32 with %02x is just a bad idea, fix it.
> > > 
> > > Why is it "just a bad idea" if the values aren't expected to exceed
> > > 0xff?
> > 
> > NAND_CMD_DEPLETE1 is 0x100 for example. I doubt anyone will use AND with
> > this controller, but I'd be much happier to see the print properly
> > matching the variable we're printing.
> 
> It will match it.  %02x doesn't restrict the output to two characters;
> it just makes sure there are at least two characters.

The output with %02x in this case is 0xffffffXY , so there is something really 
wrong going on. With %08x, the output is as expected (because that does match 
ths size of the variable).

Best regards,
Marek Vasut