[U-Boot] [PATCH v5 2/5] arm: support Thumb-1 with CONFIG_SYS_THUMB_BUILD

Stefan Roese sr at denx.de
Fri Aug 14 09:23:26 CEST 2015


Hi Albert,

On 17.07.2015 22:50, Albert ARIBAUD wrote:
> When building a Thumb-1-only target with CONFIG_SYS_THUMB_BUILD,
> some files fail to build, most of the time because they include
> mcr instructions, which only exist for Thumb-2.
>
> This patch introduces a Kconfig option CONFIG_THUMB2 and uses
> it to select between Thumb-2 and ARM mode for the aforementioned
> files.
>
> Signed-off-by: Albert ARIBAUD <albert.u.boot at aribaud.net>
> ---
> This patch has been build-tested and run-tested on ED Mini V2,
> above the "edmini: switch to SPL" patch, and found to reduce
> U-Boot size by 25% and SPL size by 14%... and to run fine. :)
>
> This patch has also been tested against side effects on the
> non-Thumb wireless_space target. The binaries produced with
> and without this patch were found to differ only by their
> version string.
>
> Changes in v5: None
> Changes in v4: None
> Changes in v3:
> - added arch/arm/lib/mem{set,cpy}.S to the list of modules
>    which should always be built in ARM state.
> - Selected HAS_THUMB2 for CPU_V7M.
> - Fixed invalidate_l2_cache() when building for Thumb-1.
>
> Changes in v2:
> - fixed a typo in the commit message
> - added file arch/arm/thumb1/include/asm/proc-armv/system.h,
>    which overrides arch/arm/include/asm/proc-armv/system.h
>    when building for Thumb-1 and provides non-functional but
>    Thumb-compilable IRQ and FIQ related macros and functions.

Whats the current status of this patch(set)? Do you plan to pull it in 
soon (when)? Or is something missing?

I'm asking since I have a ST SPEAr600 related patchset here which 
requires this THUMB1 support. And would like to commit this series soon 
as well.

Thanks,
Stefan



More information about the U-Boot mailing list