[U-Boot] confused by "upgrade_available=0\0" in include/configs/taurus.h

Wolfgang Denk wd at denx.de
Mon Jul 25 06:54:52 CEST 2016


Dear Robert,

In message <alpine.LFD.2.20.1607230737010.12216 at localhost.localdomain> you wrote:
> 
>   i note there seems to be some redundancy in the README. early on:
> 
>     911 - Bootcount:
>     912                 CONFIG_BOOTCOUNT_LIMIT
>     913                 Implements a mechanism for detecting a repeating reboot
>     914                 cycle, see:
>     915                 http://www.denx.de/wiki/view/DULG/UBootBootCountLimit
...
> and much further down:
> 
>    3088 - bootcount support:
>    3089                 CONFIG_BOOTCOUNT_LIMIT
>    3090
>    3091                 This enables the bootcounter support, see:
>    3092                 http://www.denx.de/wiki/DULG/UBootBootCountLimit

Indeed.

>    3094                 CONFIG_AT91SAM9XE
>    3095                 enable special bootcounter support on at91sam9xe based boards.
>    3096                 CONFIG_BLACKFIN
>    3097                 enable special bootcounter support on blackfin based boards.
>    3098                 CONFIG_SOC_DA8XX
>    3099                 enable special bootcounter support on da850 based boards.

This is name space pollution t best, and has potential to cause
unwanted side effects.  This needs thorough checking and cleanup, if
it should turn out thatthese macros are used only to select specific
bootcount implementations - in that case, they should be renamed into
something like CONFIG_BOOTCOUNT_* or such.

Heiko, maybe you could have a look tat that, please?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The important thing about being a leader is not being right or wrong,
but being *certain*.                    - Terry Pratchett, _Truckers_


More information about the U-Boot mailing list