[U-Boot] [PATCH v1 2/3] arm: mvebu: add DB-88F6820-AMC board

Stefan Roese sr at denx.de
Tue Sep 20 17:52:11 CEST 2016


Hi Chris,

On 19.09.2016 03:28, Chris Packham wrote:
> On Mon, Sep 19, 2016 at 12:58 PM, Simon Glass <sjg at chromium.org> wrote:
>> Hi Chris,
>>
>> On 13 September 2016 at 19:42, Chris Packham <judge.packham at gmail.com> wrote:
>>> This board is a plug in card for Marvell's switch system development
>>> kits. Form-factor aside it is similar to the DB-88F6820-GP with the
>>> following differences.
>>> - TCLK is 200MHz
>>> - SPI1 is used
>>> - No SATA
>>> - No MMC
>>> - NAND flash
>>>
>>> Signed-off-by: Chris Packham <judge.packham at gmail.com>
>>> ---
>>> I've used my work email address for the MAINTAINERS entry. Mainly
>>> because it gives a better chance at finding someone else to contact
>>> rather than a random gmail address.
>>>
>>> I've also left the copyright assignments to Stefan and Gregory since the
>>> code was derived from the -GP board.
>>>
>>>  arch/arm/dts/Makefile                         |   1 +
>>>  arch/arm/dts/armada-385-amc.dts               | 155 ++++++++++++++++++++++++++
>>>  arch/arm/mach-mvebu/Kconfig                   |   7 ++
>>>  board/Marvell/db-88f6820-amc/MAINTAINERS      |   6 +
>>>  board/Marvell/db-88f6820-amc/Makefile         |   7 ++
>>>  board/Marvell/db-88f6820-amc/db-88f6820-amc.c | 129 +++++++++++++++++++++
>>>  board/Marvell/db-88f6820-amc/kwbimage.cfg     |  12 ++
>>>  configs/db-88f6820-amc_defconfig              |  38 +++++++
>>>  include/configs/db-88f6820-amc.h              | 130 +++++++++++++++++++++
>>>  9 files changed, 485 insertions(+)
>>>  create mode 100644 arch/arm/dts/armada-385-amc.dts
>>>  create mode 100644 board/Marvell/db-88f6820-amc/MAINTAINERS
>>>  create mode 100644 board/Marvell/db-88f6820-amc/Makefile
>>>  create mode 100644 board/Marvell/db-88f6820-amc/db-88f6820-amc.c
>>>  create mode 100644 board/Marvell/db-88f6820-amc/kwbimage.cfg
>>>  create mode 100644 configs/db-88f6820-amc_defconfig
>>>  create mode 100644 include/configs/db-88f6820-amc.h
>>
>> The SPL_xxx_SUPPORT options have now moved to Kconfig, but other than that:
>>
>> Reviewed-by: Simon Glass <sjg at chromium.org>
>>
>
> Hi Simon,
>
> Thanks for the review.  I've moved the SPL_*_SUPPORT to the defconfig
> locally, I'll wait to see if there are any other comments before
> sending a v2.

I've just scanned your patches and and they look pretty good. So
please send a v2 and I'll pull them later this week.

Thanks,
Stefan


More information about the U-Boot mailing list