[U-Boot] QSPI "sf probe ...", "sf read ..." on Altera SoC FPGA

Marek Vasut marex at denx.de
Sat Jan 6 19:29:11 UTC 2018


On 01/06/2018 07:46 PM, Jason Rush wrote:
> On 1/6/2018 9:42 AM, Marek Vasut wrote:
>> On 01/06/2018 02:39 PM, Goldschmidt Simon wrote:
>>> On Fri, 05/01/2018, Marek Vasut wrote:
>>>> On 01/05/2018 08:31 PM, Goldschmidt Simon wrote:
>>>>> On Fri, 05/01/2018 Marek Vasut wrote:
>>>>>> On 01/05/2018 04:49 PM, Goldschmidt Simon wrote:
>>>>> <snip>
>>>>>
>>>>>>>>> OK, so I need these patches to get qspi work on socfpga:
>>>>>>>>>
>>>>>>>>> - Series "spi: cadence_spi: Adopt Linux DT bindings" (v4) from Jason Rush:
>>>>>>>>>   https://patchwork.ozlabs.org/project/uboot/list/?series=13864
>>>>>>>>> - Patch "Revert "spi: cadence_qspi_apb: Use 32 bit indirect read transaction when possible" (v2)
>>>>>>>>>   https://patchwork.ozlabs.org/patch/838871/
>>>>>>>> I've waited for ack/tested-by from marek or someone who usually worked
>>>>>>>> on these cadence.
>>>>>>> Vignesh acked, who already did some of the last changes. But Ok, I've
>>>>>>> added Marek to the loop.
>>>>>>>
>>>>>>> Marek, do you see any problems here? Are you running QSPI on the
>>>>>>> socfpga platform anywhere?
>>>>>> I am not entirely sure what this partial thread is all about, do you
>>>>>> need some patches Acked ? Repost them including the Acks collected
>>>>>> already and CC me, I want to review them. PW link is not enough.
>>>>> Marek, you were one of the people addressed in "to:" when Jason Rush
>>>>> sent "[PATCH v4 1/5] spi: cadence_spi: Sync DT bindings with Linux"
>>>>> and successors on Nov. 16th 2017.
>>>>>
>>>>> You were also in the "to:" field when I sent "[PATCH v4 1/5] spi:
>>>>> cadence_spi: Sync DT bindings with Linux" on Nov. 17th 2017.
>>>>>
>>>>> Should I resend them anyway?
>>>> I really dunno what to make of this sparse thread, sorry. Also, I don't
>>>> quite remember what happened in this thread on November 17th, sorry.
>>>>
>>>> So maybe you should elaborate what you expect me to do ... or just
>>>> resend the patches, yes.
>>> OK, I'll resend the patches then. I'll try to combine the 2 series
>>> into one but have to check with Jason first.
>> Super, thanks. We really need to sort this QSPI stuff out, it's been
>> going on for way too long.
>>
>> Just make sure to submit it soon, MW opens on the 8th.
>>
> 
> There was a minor upstream change to one of the files since I submitted v4 of my
> cadence device-tree patchset, so I rebased and resent the patchset as a v5.  I
> included everyone that was originally involved with the patches and added a CC
> for Marek.
> 
> This is only the patchset for the device tree changes for the cadence qspi driver,
> Simon will still have to add the patch that fixes the cache invalidation bug in the
> cadence driver.

Sigh, can we get a single patchset out which fixes the problem ?

I mean, if I understand this correctly, you're all addressing one single
problem, but with two patchsets, yes ?

-- 
Best regards,
Marek Vasut


More information about the U-Boot mailing list