[U-Boot] [PATCH] mmc: fsl_esdhc: Fix i.MX53 eSDHCv3 clock

Benoît Thébaudeau benoit.thebaudeau.dev at gmail.com
Mon Jan 15 21:11:25 UTC 2018


Hi Stefano,

On Mon, Jan 15, 2018 at 11:59 AM, Stefano Babic <sbabic at denx.de> wrote:
> On 15/01/2018 00:46, Benoît Thébaudeau wrote:
>> +     int pre_div = regs == (struct fsl_esdhc *)MMC_SDHC3_BASE_ADDR ? 2 : 1;
>
> It is surely a question of taste - but is it not cleared to surround the
> expression with parenthesis ? (regs == .... )

I can send a v2 for that if you want. Which of the following do you
prefer (personally, I'd say the last one)?

int pre_div = (regs == (struct fsl_esdhc *)MMC_SDHC3_BASE_ADDR ? 2 : 1);
int pre_div = (regs == (struct fsl_esdhc *)MMC_SDHC3_BASE_ADDR) ? 2 : 1;

Note that this patch can be tested with the 2nd MMC on i.MX53 Loco if
anyone has this board. Wladimir?

Best regards,
Benoît


More information about the U-Boot mailing list