[U-Boot] [PATCH] arm64 :show_regs: show the address before relocation

[Karl Beldan]

On Tue, Nov 28, 2017 at 10:08:08AM +0800, Peng Fan wrote:
> After relocation, when error happends, it is hard to track
> ELR and LR with asm file objdumped from elf file.
> 
> So subtract the gd->reloc_off the reflect the compliation address.
> 
> Signed-off-by: Peng Fan <peng.fan at nxp.com>
> ---
>  arch/arm/lib/interrupts_64.c | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/lib/interrupts_64.c b/arch/arm/lib/interrupts_64.c
> index 7c9cfce69f..cbcfeec2b0 100644
> --- a/arch/arm/lib/interrupts_64.c
> +++ b/arch/arm/lib/interrupts_64.c
> @@ -9,6 +9,7 @@
>  #include <linux/compiler.h>
>  #include <efi_loader.h>
>  
> +DECLARE_GLOBAL_DATA_PTR;
>  
>  int interrupt_init(void)
>  {
> @@ -29,8 +30,13 @@ void show_regs(struct pt_regs *regs)
>  {
>  	int i;
>  
> -	printf("ELR:     %lx\n", regs->elr);
> -	printf("LR:      %lx\n", regs->regs[30]);
> +	if (gd->flags & GD_FLG_RELOC) {
> +		printf("ELR:     %lx\n", regs->elr - gd->reloc_off);
> +		printf("LR:      %lx\n", regs->regs[30] - gd->reloc_off);
> +	} else {
> +		printf("ELR:     %lx\n", regs->elr);
> +		printf("LR:      %lx\n", regs->regs[30]);
> +	}
>  	for (i = 0; i < 29; i += 2)
>  		printf("x%-2d: %016lx x%-2d: %016lx\n",
>  		       i, regs->regs[i], i+1, regs->regs[i+1]);

Hi,

It is useful to show the relocated address, the kind of local mods I too
have had for a while.
But here you dropped the hw register values altogether, instead of
displaying both, which I guess I am not the only one to not be happy
about.

Regards,
Karl