[U-Boot] Convert CONFIG_SYS_BOOT_GET_{CMDLINE, KBD} to Kconfig

Tom Rini trini at konsulko.com
Mon Jan 22 21:42:53 UTC 2018


On Thu, Dec 28, 2017 at 01:25:13AM -0600, Derald D. Woods wrote:

> This converts the following to Kconfig:
> 	CONFIG_SYS_BOOT_GET_CMDLINE
> 	CONFIG_SYS_BOOT_GET_KBD
> 
> Additionally, ARM now selects CONFIG_SYS_BOOT_GET_CMDLINE. This enables
> the 'boot_get_cmdline' call to be reached from 'image_setup_linux' in
> "common/image.c".
> 
> Signed-off-by: Derald D. Woods <woods.technical at gmail.com>
> ---
>  Kconfig                           | 12 ++++++++++++
>  arch/Kconfig                      |  5 +++++
>  arch/m68k/include/asm/config.h    |  2 --
>  arch/powerpc/include/asm/config.h |  2 --
>  scripts/config_whitelist.txt      |  2 --
>  5 files changed, 17 insertions(+), 6 deletions(-)

Why are you enabling this on ARM as well here?  It causes a size grow
(of course, we're adding in a function) on all ARM boards and I don't
quite see why we need to put a copy of the bootargs in that location.

Off the top of my head it seems like it only makes sense on pre-DTB
PowerPC where the cmdline needed to be in a good location.  On pre-DTB
ARM that's done via ATAGS instead, so already covered.  Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180122/3bc753b5/attachment.sig>


More information about the U-Boot mailing list