[U-Boot] [PATCH 2/4] usb: gadget: dwc2: Fix warning over 32bit vs 64bit targets

[Marek Vasut]

On 01/27/2018 09:17 PM, Dr. Philipp Tomsich wrote:
> 
>> On 27 Jan 2018, at 20:56, Tom Rini <trini at konsulko.com> wrote:
>>
>> On Sat, Jan 27, 2018 at 08:52:43PM +0100, Marek Vasut wrote:
>>> On 01/27/2018 08:48 PM, Tom Rini wrote:
>>>> When we have a driver that is used on both 32bit and 64bit targets and
>>>> we are talking about address space we cannot use u64 nor u32 and instead
>>>> need to use phys_addr_t.
>>>
>>> Can someoneone pass in a pointer above 32bit address range ? That might
>>> cause some mess ...
>>
>> On rockchip, where this gets used as well, it comes down to writel and a
>> warning about "cast from pointer to integer of different size”.
> 
> I had submitted a patch to resolve this middle of last year
> 	https://patchwork.ozlabs.org/patch/783541/
> and used the rationale that this change would make the truncation explicit.
> 
> I don’t recall why did this didn’t move anywhere, but darkly remember the
> discussion veering towards bounce buffers…

I'll just bounce this to Lukasz, since he maintains the gadget, but the
DWC2 UDC driver looks really dark ... ew ...

-- 
Best regards,
Marek Vasut