[U-Boot] [PATCH 2/4] usb: gadget: dwc2: Fix warning over 32bit vs 64bit targets

[Lukasz Majewski]

Hi Marek, Tom, Philipp,

> On 01/27/2018 09:17 PM, Dr. Philipp Tomsich wrote:
> >   
> >> On 27 Jan 2018, at 20:56, Tom Rini <trini at konsulko.com> wrote:
> >>
> >> On Sat, Jan 27, 2018 at 08:52:43PM +0100, Marek Vasut wrote:  
> >>> On 01/27/2018 08:48 PM, Tom Rini wrote:  
> >>>> When we have a driver that is used on both 32bit and 64bit
> >>>> targets and we are talking about address space we cannot use u64
> >>>> nor u32 and instead need to use phys_addr_t.  
> >>>
> >>> Can someoneone pass in a pointer above 32bit address range ? That
> >>> might cause some mess ...  
> >>
> >> On rockchip, where this gets used as well, it comes down to writel
> >> and a warning about "cast from pointer to integer of different
> >> size”.  

I'm not sure if DWC2 is prepared to work with 64B pointers. As fair as
I remember it works with 32B.

> > 
> > I had submitted a patch to resolve this middle of last year
> > 	https://patchwork.ozlabs.org/patch/783541/

Unfortunately, I did not received this patch.

> > and used the rationale that this change would make the truncation
> > explicit.
> > 
> > I don’t recall why did this didn’t move anywhere, but darkly
> > remember the discussion veering towards bounce buffers…  
> 
> I'll just bounce this to Lukasz, since he maintains the gadget, but
> the DWC2 UDC driver looks really dark ... ew ...
> 




Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180128/91848388/attachment.sig>