[U-Boot] [PATCH] serial: Make full device search optional

Derald Woods woods.technical at gmail.com
Tue Jan 30 13:09:09 UTC 2018


On Jan 30, 2018 3:17 AM, "Alexander Graf" <agraf at suse.de> wrote:

On 01/30/2018 12:41 AM, Derald D. Woods wrote:

> On Mon, Jan 29, 2018 at 07:46:09AM -0600, Derald Woods wrote:
>
>> On Jan 29, 2018 6:57 AM, "Alexander Graf" <agraf at suse.de> wrote:
>>
>> Commit 608b0c4ad4e5ec0c ("serial: Use next serial device if probing
>> fails")
>> added code to search for more serial devices if the default one was not
>> probed correctly.
>>
>> Unfortunately, that breaks omap3_evm. So while investigating why that is
>> the case, let's disable the full search for everyone but bcm283x where it
>> is needed.
>>
>> Fixes: 608b0c4ad4e5ec0c ("serial: Use next serial device if probing
>> fails")
>> Reported-by: Derald D. Woods <woods.technical at gmail.com>
>> Signed-off-by: Alexander Graf <agraf at suse.de>
>>
>> ---
>>
>> Derald, could you please test this patch and verify it does indeed unbreak
>> omap3_evm?
>>
>> The omap3_evm boots now with this patch applied on master. If I enable
> SERIAL_SEARCH_ALL, it does not boot. I always build cleanly using the
> default config only. On failure, there is no console input/output and
> the board unresponsive.
>

So SPL is already broken? Can you try a known working SPL with
SERIAL_SEARCH_ALL=y U-Boot payload on top? Does that work?


I will give that path a try and see what I can discover. Again, it will be
later today or tomorrow before I can get to this. This is why I asked what
should the board code actually look like. As the omap3_evm is ahead of some
other OMAP34XX boards currently, a good working example would be helpful.
If omap3_evm becomes the example, let's make it a good one.

Derald


More information about the U-Boot mailing list