[U-Boot] [PATCH v2 1/2] splash: Use splashfile instead of location->name

[Melin Tomas]

Hi Mark,

>> Could fallback here instead be "location->name" as before, keeping
>> compability with the current implementation? I.e.
>>
>> +	if (!splash_file)
>> +		splash_file = location->name;
> Can you point me to the 3 upstream boards which are relying on this?
>
> Is it compulab/cm_fx6, compulab/cm_t35, and menlo/m53menlo?
>
> compulab/cm_fx6 uses .name = "nand" and SPLASH_STORAGE_RAW. Thus it is
> not be affected by changes in splash_load_fit().
>
> http://git.denx.de/?p=u-boot.git;a=blob;f=board/compulab/cm_t35/cm_t35.c;h=4d171f4900be8eb6deea730435825b3edd805612;hb=HEAD#l63
>
> compulab/cm_fx6 uses four different .name and splash locations. They are
> either SPLASH_STORAGE_RAW or SPLASH_STORAGE_FS. Thus it is not affected.
>
> http://git.denx.de/?p=u-boot.git;a=blob;f=board/compulab/cm_fx6/cm_fx6.c;h=d42f57d4b7014b3bd6550af186504f2c580585d2;hb=HEAD#l43
>
> menlo/m53menlo uses .name = "mmc_fs" and SPLASH_STORAGE_FS. Thus it is
> not affected.
>
> http://git.denx.de/?p=u-boot.git;a=blob;f=board/menlo/m53menlo/m53menlo.c;h=6bdd6d5b234dd0474b8288abda32b8099a570348;hb=HEAD#l336
>
> I conclude that no upstream board is actually affected. They would only be affecte if they would use SPLASH_STORAGE_FIT.

You are right, indeed upstream boards should be ok. However, some other 
non upstream boards I know of would be affected.

So my initial question still stands, could existing implementation be 
kept as fallback?

+	if (!splash_file)
+		splash_file = location->name;

location->name has worked fine for those cases, so it would be nice to 
keep that option intact.

BR,

Tomas


>
> http://git.denx.de/?p=u-boot.git;a=blob;f=common/splash_source.c;h=62763b9ebd5698b454280a6d4b62cd23a7312786;hb=HEAD#l409
>
> Regards,
> Mark
>
>
> Building Technologies, Panel Software Fire (BT-FIR/ENG1)
> Bosch Sicherheitssysteme GmbH | Postfach 11 11 | 85626 Grasbrunn | GERMANY | www.boschsecurity.com
>
> Sitz: Stuttgart, Registergericht: Amtsgericht Stuttgart HRB 23118
> Aufsichtsratsvorsitzender: Christian Fischer; Geschäftsführung: Tanja Rückert, Andreas Bartz, Thomas Quante, Bernhard Schuster