[U-Boot] [PATCH v2 1/2] splash: Use splashfile instead of location->name
sbabic at denx.de
Wed Feb 6 14:03:30 UTC 2019
On 06/02/19 14:44, Melin Tomas wrote:
> Hi Mark,
>>> Could fallback here instead be "location->name" as before, keeping
>>> compability with the current implementation? I.e.
>>> + if (!splash_file)
>>> + splash_file = location->name;
>> Can you point me to the 3 upstream boards which are relying on this?
>> Is it compulab/cm_fx6, compulab/cm_t35, and menlo/m53menlo?
>> compulab/cm_fx6 uses .name = "nand" and SPLASH_STORAGE_RAW. Thus it is
>> not be affected by changes in splash_load_fit().
>> compulab/cm_fx6 uses four different .name and splash locations. They are
>> either SPLASH_STORAGE_RAW or SPLASH_STORAGE_FS. Thus it is not affected.
>> menlo/m53menlo uses .name = "mmc_fs" and SPLASH_STORAGE_FS. Thus it is
>> not affected.
>> I conclude that no upstream board is actually affected. They would only be affecte if they would use SPLASH_STORAGE_FIT.
> You are right, indeed upstream boards should be ok. However, some other
> non upstream boards I know of would be affected.
Well, to be honest: we cannot care in mainline about non upstream
boards. They are not tested at all and they can go broken at any time.
If people / companies want that their board are efficeintly maintained,
they have to take the path to work for including boards into official
tree, and maintain them.
> So my initial question still stands, could existing implementation be
> kept as fallback?
> + if (!splash_file)
> + splash_file = location->name;
> location->name has worked fine for those cases, so it would be nice to
> keep that option intact.
>> Building Technologies, Panel Software Fire (BT-FIR/ENG1)
>> Bosch Sicherheitssysteme GmbH | Postfach 11 11 | 85626 Grasbrunn | GERMANY | www.boschsecurity.com
>> Sitz: Stuttgart, Registergericht: Amtsgericht Stuttgart HRB 23118
>> Aufsichtsratsvorsitzender: Christian Fischer; Geschäftsführung: Tanja Rückert, Andreas Bartz, Thomas Quante, Bernhard Schuster
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
More information about the U-Boot