[U-Boot] [PATCH v2 1/2] splash: Use splashfile instead of location->name

[Jonas Mark (BT-FIR/ENG1)]

Hi Tomas,

> > I conclude that no upstream board is actually affected. They would only
> be affecte if they would use SPLASH_STORAGE_FIT.
> 
> You are right, indeed upstream boards should be ok. However, some
> other non upstream boards I know of would be affected.
> 
> So my initial question still stands, could existing implementation be kept
> as fallback?
> 
> +	if (!splash_file)
> +		splash_file = location->name;
> 
> location->name has worked fine for those cases, so it would be nice to
> keep that option intact.

I think that the .name field of struct splash_location is actually
intended to hold a human readable name for the storage itself. That the
code so far uses the storage location name synonymously with the splash
screen name is unfortunate. That's why we decided to fix this. I am
convinced that the patch actually makes it easier for others to start
reading splash screens from a FIT image.

Why do I think so? Because the behavior is now consistent to
what splash_load_fs() does. That is, if there is an environment variable
"splashfile" the splash screen name is taken from there. Else, the fixed
default name "splash.bmp" is used.

Regards,
Mark


Building Technologies, Panel Software Fire (BT-FIR/ENG1) 
Bosch Sicherheitssysteme GmbH | Postfach 11 11 | 85626 Grasbrunn | GERMANY | www.boschsecurity.com

Sitz: Stuttgart, Registergericht: Amtsgericht Stuttgart HRB 23118 
Aufsichtsratsvorsitzender: Christian Fischer; Geschäftsführung: Tanja Rückert, Andreas Bartz, Thomas Quante, Bernhard Schuster