[U-Boot] [BUG] booting on the Tinker Board (tinker-rk3288_defconfig) is broken

[Philipp Tomsich]

> On 09.02.2019, at 17:39, Heinrich Schuchardt <xypron.glpk at gmx.de> wrote:
> 
> On 2/9/19 4:24 PM, Philipp Tomsich wrote:
>> 
>> 
>>> On 09.02.2019, at 16:08, Philipp Tomsich <philipp.tomsich at theobroma-systems.com> wrote:
>>> 
>>> Heinrich,
>>> 
>>> My guess is that this is fallout from David Wu’s new pinctrl driver
>>> (which has really been the bulk of changes in this cycle).  I can’t
>>> test or debug on the rk3288 due to a lack of hardware.
>> 
>> If you want to start digging, that the changes in
>> 
>>> commit 08c817c39908f9d120df1e4c90ddad4a11fc3891
>>> Author: David Wu <david.wu at rock-chips.com>
>>> Date:   Wed Jan 2 20:51:00 2019 +0800
>>> 
>>>    ARM: rockchip: Remove the pinctrl request at rk3288-board-spl
>>> 
>>>    If we use the new pinctrl driver, the pinctrl setup will be done
>>>    by device probe. Remove the pinctrl setup at rk3288-board-spl.
>>> 
>>>    Signed-off-by: David Wu <david.wu at rock-chips.com>
>>>    Reviewed-by: Kever Yang <kever.yang at rock-chips.com>
>>>    Reviewed-by: Philipp Tomsich <philipp.tomsich at theobroma-systems.com>
>> 
>> 
>> look like they have the potential to break everything, including the
>> UART pinctrl.
>> 
>> Thanks,
>> Philipp.,
>> 
> Hello Philipp,
> 
> I would not know how to analyze the bug if there isn't even a console.
> If David or you send me a git branch to compile I will test it.

We’ll have to wait for David to come back from CNY, apparently.

> Has any of the rk3288 boards been tested before merging?

I would assume so, as this patchset is coming from Rockchips and Kever
gave his Reviewed-by…

That said, I have been fighting issues from this patchset when trying to read
from devices on the i2c0 bus on a RK3399—which had me add a “simple”
pinctrl device again, as pulling all the dependencies into the SPL is a pain.

Unfortunately, in this merge I had to make a judgement call between insisting
on code-quality and getting the full pinctrl-driver merged.  With this release
cycle being longer and having 5 RCs, I figured we’ll have time to iron out any
wrinkles...

> I think we should keep Simon in CC as he is one of the ROCKCHIP maintainers.

I didn’t intentionally drop him. It was either clumsy fingers or Reply-All not
replying to all.

Cheers,
Philipp.