[U-Boot] [PATCH v2] ARM: tegra: enable ums on nyan boards
Tristan Bastian
tristan-c.bastian at gmx.de
Fri Feb 15 01:07:05 UTC 2019
Am 15.02.2019 00:42 schrieb Stephen Warren <swarren at wwwdotorg.org>:
>
> On 2/14/19 4:25 PM, Tristan Bastian wrote:
> > This patch enables UMS on the nyan devices like the nyan-big.
> > A patch like this has been sent in by Stephen Warren some time ago for other tegra devices: commit e6607cffef965011ef0ddc0fbe6f4b7c0d53aeec
> > But the nyan devices never received that functionality.
> >
> > v2: fixed corrupted patch
>
> That should be below the ---, but I assume Tom can fix that when
> applying the patch.
>
> Acked-by: Stephen Warren <swarren at nvidia.com>
> but...
>
> > diff --git a/arch/arm/dts/tegra124-nyan.dtsi b/arch/arm/dts/tegra124-nyan.dtsi
> > index 51895e4816..2b28fe1497 100644
> > --- a/arch/arm/dts/tegra124-nyan.dtsi
> > +++ b/arch/arm/dts/tegra124-nyan.dtsi
> > @@ -414,6 +414,7 @@
> >
> > usb at 7d000000 { /* Rear external USB port. */
> > status = "okay";
> > + dr_mode = "otg";
> > nvidia,vbus-gpio = <&gpio TEGRA_GPIO(N, 4) GPIO_ACTIVE_HIGH>;
> > };
>
> Do you also need to add aliases for the USB nodes, like I did in my
> similar patch:
>
> > diff --git a/arch/arm/dts/tegra124-jetson-tk1.dts b/arch/arm/dts/tegra124-jetson-tk1.dts
> > index 52e8c0e59c6b..464287e03ecf 100644
> > --- a/arch/arm/dts/tegra124-jetson-tk1.dts
> > +++ b/arch/arm/dts/tegra124-jetson-tk1.dts
> > @@ -17,7 +17,8 @@
> > sdhci1 = "/sdhci at 700b0400";
> > spi0 = "/spi at 7000d400";
> > spi1 = "/spi at 7000da00";
> > - usb0 = "/usb at 7d008000";
> > + usb0 = "/usb at 7d000000";
> > + usb1 = "/usb at 7d008000";
> > };
At least for nyan-big this is done in the: tegra124-nyan-big.dts file.
So there is no need to also do this here.
More information about the U-Boot
mailing list