[U-Boot] [REGRESSION: PATCH 34/34] drivers/net/fec: phy_init: remove redundant logic

[Marcel Ziswiler]

Hi Hannes

On Tue, 2019-03-26 at 10:15 +0100, Hannes Schmelzer wrote:
> On 3/25/19 5:07 PM, Marcel Ziswiler wrote:
> > Hi Stefano
> > 
> > On Wed, 2019-03-13 at 08:28 +0000, sbabic at denx.de wrote:
> > > > The phy_connect_dev(...) function from phy.c does all the
> > > > handling
> > > > (inclusive catching fixed-link).
> > > > So we drop here the single steps and call just
> > > > phy_connect_dev(...).
> > > > Signed-off-by: Hannes Schmelzer <
> > > > hannes.schmelzer at br-automation.com
> > > > Acked-by: Joe Hershberger <joe.hershberger at ni.com>
> > > Applied to u-boot-imx, master, thanks !
> > > 
> > > Best regards,
> > > Stefano Babic
> > Unfortunately, this commit broke Ethernet on the Vybrid. When re-
> > basing
> > my Colibri VF50/VF61 clean-up patch set ("colibri vybrid fixes,
> > device
> > tree enablement and driver model conversion") I noticed that
> > Ethernet
> > no longer works giving the following error messages:
> > 
> > Net:   Could not get PHY for FEC0: addr -19
> > eth-1: fec at 400d1000
> > Colibri VFxx # dhcp
> > Could not get PHY for FEC0: addr -19
> > Could not get PHY for FEC0: addr -19
> > Could not get PHY for FEC0: addr -19
> > Could not get PHY for FEC0: addr -19
> > No ethernet found.
> > Could not get PHY for FEC0: addr -19
> > Colibri VFxx #
> > 
> > Bisecting points to this commit and reverting it indeed makes it
> > work
> > again.
> > 
> > Has anybody else seen a similar issue (e.g. @Lukasz on pcm052)?
> > 
> > Cheers
> > 
> > Marcel
> > _______________________________________________
> > U-Boot mailing list
> > U-Boot at lists.denx.de
> > https://lists.denx.de/listinfo/u-boot
> Hi Marcel,
> does this board use DM ?

Yes, I moved it to DM. The latest patch set is the following:

https://patchwork.ozlabs.org/cover/1064570/

Also available on our git server here:

http://git.toradex.com/cgit/u-boot-toradex.git/log/?h=for-next

> which defconfig uses the board?

That would be colibri_vf_defconfig.

> cheers,
> Hannes

Cheers

Marcel