[PATCH 4/6] dm: sysreset: wait after reset message
Simon Glass
sjg at chromium.org
Tue Aug 4 04:00:41 CEST 2020
Hi Heinrich,
On Wed, 29 Jul 2020 at 09:43, Heinrich Schuchardt <xypron.glpk at gmx.de> wrote:
>
> In our Python tests we expect to see the word "resetting". It may be
> truncated if we reset before the serial console buffer is transferred.
>
> Wait for 100 ms between the "resetting ..." message and the actual reset
> like we do when powering off.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
> ---
> drivers/sysreset/sysreset-uclass.c | 1 +
> 1 file changed, 1 insertion(+)
Please add a comment as to the reason for the delay. and how you chose
the value.
Reviewed-by: Simon Glass <sjg at chromium.org>
>
> diff --git a/drivers/sysreset/sysreset-uclass.c b/drivers/sysreset/sysreset-uclass.c
> index 995240f0cb..3f5414ed1f 100644
> --- a/drivers/sysreset/sysreset-uclass.c
> +++ b/drivers/sysreset/sysreset-uclass.c
> @@ -117,6 +117,7 @@ void reset_cpu(ulong addr)
> int do_reset(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[])
> {
> printf("resetting ...\n");
> + mdelay(100);
>
> sysreset_walk_halt(SYSRESET_COLD);
>
> --
> 2.27.0
>
More information about the U-Boot
mailing list