[PATCH v1] spi: cadence-qspi: Fix QSPI write issues

Tan, Ley Foon ley.foon.tan at intel.com
Thu Aug 27 08:09:05 CEST 2020



> -----Original Message-----
> From: U-Boot <u-boot-bounces at lists.denx.de> On Behalf Of Tan, Ley Foon
> Sent: Wednesday, August 5, 2020 6:00 PM
> To: Ang, Chee Hong <chee.hong.ang at intel.com>; u-boot at lists.denx.de
> Cc: Phil Edworthy <PHIL.EDWORTHY at renesas.com>; Vignesh R
> <vigneshr at ti.com>; Tom Rini <trini at konsulko.com>; See, Chin Liang
> <chin.liang.see at intel.com>; Chee, Tien Fong <tien.fong.chee at intel.com>;
> Lim, Elly Siew Chin <elly.siew.chin.lim at intel.com>
> Subject: RE: [PATCH v1] spi: cadence-qspi: Fix QSPI write issues
> 
> 
> 
> > -----Original Message-----
> > From: Ang, Chee Hong <chee.hong.ang at intel.com>
> > Sent: Wednesday, August 5, 2020 5:33 PM
> > To: u-boot at lists.denx.de
> > Cc: Phil Edworthy <PHIL.EDWORTHY at renesas.com>; Vignesh R
> > <vigneshr at ti.com>; Tom Rini <trini at konsulko.com>; See, Chin Liang
> > <chin.liang.see at intel.com>; Tan, Ley Foon <ley.foon.tan at intel.com>;
> > Ang, Chee Hong <chee.hong.ang at intel.com>; Chee, Tien Fong
> > <tien.fong.chee at intel.com>; Lim, Elly Siew Chin
> > <elly.siew.chin.lim at intel.com>
> > Subject: [PATCH v1] spi: cadence-qspi: Fix QSPI write issues
> >
> > QSPI driver perform chip select on every flash read/write access. The
> > driver need to disable/enable the QSPI controller while performing
> > chip select. This may cause some data lost especially the QSPI
> > controller is configured to run at slower speed as it may take longer time to
> access the flash device.
> > This patch prevent the driver from disable/enable the QSPI controller
> > too soon and inadvertently halting any ongoing flash read/write access
> > by ensuring the QSPI controller is always in idle mode after each
> > read/write access.
> >
> > Signed-off-by: Chee Hong Ang <chee.hong.ang at intel.com>
> > ---
> >  drivers/spi/cadence_qspi_apb.c | 9 +++++++++
> >  1 file changed, 9 insertions(+)
> >
> 
> Reviewed-by: Ley Foon Tan <ley.foon.tan at intel.com>
> 
> Regards
> Ley Foon

+ Jagan, SPI maintainer.

Jagan, can you help integrate this patch?

Regards
Ley Foon


More information about the U-Boot mailing list