[PATCH v2 24/25] x86: mp: Add more comments to the module

Wolfgang Wallner wolfgang.wallner at br-automation.com
Tue Jun 16 13:31:03 CEST 2020


Hi Simon,

> -----"Simon Glass" <sjg at chromium.org> schrieb: -----
> Betreff: [PATCH v2 24/25] x86: mp: Add more comments to the module
> 
> Add a description of how this module works and also some missing function
> comments.

Great to see more documenation :)

> 
> Drop struct cpu_map since it is not used.
> 
> Signed-off-by: Simon Glass <sjg at chromium.org>
> ---
> 
> Changes in v2:
> - Add a new patch with more comments
> 
>  arch/x86/cpu/mp_init.c    | 91 ++++++++++++++++++++++++++++++++++++++-
>  arch/x86/include/asm/mp.h | 14 +++++-
>  2 files changed, 102 insertions(+), 3 deletions(-)
> 

[snip]

> + *
> + * After being started, each AP runs the code in ap_start16, switches to 32-bit
> + * mode, runs the code at ap_start, then jumps to c_handler which is ap_init().
> + * This runs a very simple 'flight plan' described in* mp_steps. This sets up

Should this be "in *mp_steps"? Or "in mp_steps"?

[snip]

Reviewed-by: Wolfgang Wallner <wolfgang.wallner at br-automation.com>



More information about the U-Boot mailing list