[PATCH v2 24/25] x86: mp: Add more comments to the module

Bin Meng bmeng.cn at gmail.com
Sun Jun 28 10:40:34 CEST 2020


Hi Simon,

On Mon, Jun 15, 2020 at 1:00 AM Simon Glass <sjg at chromium.org> wrote:
>
> Add a description of how this module works and also some missing function
> comments.
>
> Drop struct cpu_map since it is not used.

"struct cpu_map" was already dropped in patch "[v2,10/25] x86: mp:
Support APs waiting for instructions"
http://patchwork.ozlabs.org/project/uboot/patch/20200614105621.v2.10.I5cdb6d2b53a528eaebda2227b8cdfe26c4c73ceb@changeid/

So you may adjust the codes to drop "struct cpu_map" in this patch instead?

>
> Signed-off-by: Simon Glass <sjg at chromium.org>
> ---
>
> Changes in v2:
> - Add a new patch with more comments
>
>  arch/x86/cpu/mp_init.c    | 91 ++++++++++++++++++++++++++++++++++++++-
>  arch/x86/include/asm/mp.h | 14 +++++-
>  2 files changed, 102 insertions(+), 3 deletions(-)
>

Other than the commit message,
Reviewed-by: Bin Meng <bmeng.cn at gmail.com>

Regards,
Bin


More information about the U-Boot mailing list