U-Boot atheros PHY support and cubox ethernet

[Vladimir Oltean]

On Tue, 16 Jun 2020 at 23:10, Tom Rini <trini at konsulko.com> wrote:
>
> On Tue, Jun 16, 2020 at 10:58:26PM +0300, Vladimir Oltean wrote:
> > Hi Tom,
> >
> > On Tue, 16 Jun 2020 at 22:55, Tom Rini <trini at konsulko.com> wrote:
> > >
> > > Hey all,
> > >
> > > In commit 4346df3392c0 ("phy: atheros: Make RGMII Tx delays actually
> > > configurable for AR8035") we brought in changes to get in to line with
> > > upstream linux kernel support for this PHY and in turn deal with more
> > > "driver was wrong, DT was wrong too" changes.  Now the problem I have is
> > > that ethernet on my Hummingboard doesn't work AND as far as I can tell,
> > > the DTB is correct and saying phy-mode = "rgmii-id" now not "rgmii".  It
> > > also looks to match what's in v5.7 for the kernel.  What do I need to do
> > > here next?  Thanks!
> > >
> > > --
> > > Tom
> >
> > Reverting 4346df3392c0 makes your interface work?
>
> Yup.
>
> > What is the DTS path that your hummingboard uses?
>
> Good question.  Per board/solidrun/mx6cuboxi/mx6cuboxi.c:
> /*
>  * This is not a perfect match. Avoid dependency on the DM GPIO driver
>  * needed
>  * for accurate board detection. Hummingboard2 DT is good enough for
>  * U-Boot on
>  * all Hummingboard/Cubox-i platforms.
>  */
> so arch/arm/dts/imx6dl-hummingboard2-emmc-som-v15.dts is the base.  But
> the board really is the original hummingboard platform.  Thanks!
>
> --
> Tom

Does it work if you say PHY_INTERFACE_MODE_RGMII_ID here?
https://gitlab.denx.de/u-boot/u-boot/-/blob/master/drivers/net/fec_mxc.c#L1232

-Vladimir