[PATCH v2] ARM: dts: imx6q-tbs2910: Fix Ethernet regression

Stefano Babic sbabic at denx.de
Thu Jun 25 16:18:00 CEST 2020


On 25.06.20 15:55, Fabio Estevam wrote:
> Hi Tom,
> 
> On Thu, Jun 25, 2020 at 10:52 AM Soeren Moch <smoch at web.de> wrote:
>>
>> On 25.06.20 13:14, Fabio Estevam wrote:
>>> Since commit:
>>>
>>> commit 6333cbb3817ed551cd7d4e92f7359c73ccc567fc
>>> Author: Michael Walle <michael at walle.cc>
>>> Date:   Thu May 7 00:11:58 2020 +0200
>>>
>>>     phy: atheros: ar8035: remove static clock config
>>>
>>>     We can configure the clock output in the device tree. Disable the
>>>     hardcoded one in here. This is highly board-specific and should have
>>>     never been enabled in the PHY driver.
>>>
>>>     If bisecting shows that this commit breaks your board it probably
>>>     depends on the clock output of your Atheros AR8035 PHY. Please have a
>>>     look at doc/device-tree-bindings/net/phy/atheros.txt. You need to set
>>>     "clk-out-frequency = <125000000>" because that value was the hardcoded
>>>     value until this commit.
>>>
>>>     Signed-off-by: Michael Walle <michael at walle.cc>
>>>     Acked-by: Joe Hershberger <joe.hershberger at ni.com>
>>>
>>> , the clock output setting for the AR803x driver is removed from being
>>> hardcoded in the PHY driver and should be passed via device tree instead.
>>>
>>> Update the device tree with the "qca,clk-out-frequency" property so that
>>> Ethernet can work again.
>>>
>>> Reported-by: Soeren Moch <smoch at web.de>
>>> Signed-off-by: Fabio Estevam <festevam at gmail.com>
>> Tested-by: Soeren Moch <smoch at web.de>
> 
> My understanding is that Stefano does not have any other pull requests
> for 2020.07.
> 

Yes, I do not see (this is an exception) other urgent patches that
should flow into the release.

> In this case, could you apply this regression fix directly?
> 

+1

Thanks,
Stefano

> Thanks
> 


-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================


More information about the U-Boot mailing list