[PATCH v2 8/9] arm: dts: ls1028a: sync the fsl-ls1028a.dtsi with linux

Michael Walle michael at walle.cc
Wed Sep 1 16:51:13 CEST 2021


Am 2021-09-01 13:27, schrieb Vladimir Oltean:
> On Wed, Sep 01, 2021 at 10:55:21AM +0200, Michael Walle wrote:
>>  		sata: sata at 3200000 {
>>  			compatible = "fsl,ls1028a-ahci";
>> -			reg = <0x0 0x3200000 0x0 0x10000	/* ccsr sata base */
>> -				   0x7 0x100520  0x0 0x4>;		/* ecc sata addr*/
>> -			reg-names = "sata-base", "ecc-addr";
>> +			reg = <0x0 0x3200000 0x0 0x10000>,
>> +				<0x7 0x100520 0x0 0x4>;
>> +			reg-names = "ahci", "sata-ecc";
> 
> Again, same problem. The drivers/ata/sata_ceva.c driver calls
> dev_read_resource_byname(dev, "ecc-addr") (but not for "sata-base",
> apparently).
> 
> If you don't want to convert all occurrences of "ecc-addr" to
> "sata-ecc", then at least add a fallback call to 
> dev_read_resource_byname.

This is also missing proper bindings documentation in linux :(
I guess it's safe to assume the current linux device tree binding
is the correct one.

-michael


More information about the U-Boot mailing list