[U-Boot] [PATCH v9 18/30] nand: mxc: Switch NAND SPL to generic SPL

[Benoît Thébaudeau]

On Tuesday, April 9, 2013 6:56:18 PM, Benoît Thébaudeau wrote:
> Hi Fabio,
> 
> On Tuesday, April 9, 2013 6:40:45 PM, Fabio Estevam wrote:
> > Hi Benoît,
> > 
> > On Tue, Apr 9, 2013 at 11:38 AM, Benoît Thébaudeau
> > <benoit.thebaudeau at advansee.com> wrote:
> > 
> > > Can you try different values for the following configs in mx31pdk.h?
> > >  - CONFIG_SYS_NAND_U_BOOT_SIZE
> > >  - CONFIG_SPL_TEXT_BASE
> > >  - CONFIG_SYS_TEXT_BASE
> > >  - (CONFIG_ENV_OFFSET)
> > >  - (CONFIG_ENV_OFFSET_REDUND)
> > >
> > > I would try:
> > >  - 0x40000 for CONFIG_SYS_NAND_U_BOOT_SIZE
> > >  - 0x86000000 for CONFIG_SPL_TEXT_BASE
> > >  - 0x87000000 for CONFIG_SYS_TEXT_BASE
> > 
> > Thanks, that did the trick!
> > 
> > With the changes below I am able to get into the U-boot prompt:
> > 
> > diff --git a/include/configs/mx31pdk.h b/include/configs/mx31pdk.h
> > index 8f12825..d82bf65 100644
> > --- a/include/configs/mx31pdk.h
> > +++ b/include/configs/mx31pdk.h
> > @@ -51,8 +51,8 @@
> >  #define CONFIG_SPL_MAX_SIZE	2048
> >  #define CONFIG_SPL_NAND_SUPPORT
> > 
> > -#define CONFIG_SPL_TEXT_BASE	0x87ec0000
> > -#define CONFIG_SYS_TEXT_BASE	0x87f00000
> > +#define CONFIG_SPL_TEXT_BASE	0x86000000
> > +#define CONFIG_SYS_TEXT_BASE	0x87000000
> > 
> >  #ifndef CONFIG_SPL_BUILD
> >  #define CONFIG_SKIP_LOWLEVEL_INIT
> > @@ -69,8 +69,6 @@
> > 
> >  #define CONFIG_MXC_UART
> >  #define CONFIG_MXC_UART_BASE	UART1_BASE
> > -#define CONFIG_HW_WATCHDOG
> > -#define CONFIG_IMX_WATCHDOG
> >  #define CONFIG_MXC_GPIO
> > 
> >  #define CONFIG_HARD_SPI
> > @@ -199,7 +197,7 @@
> > 
> >  /* Start copying real U-boot from the second page */
> >  #define CONFIG_SYS_NAND_U_BOOT_OFFS	CONFIG_SPL_PAD_TO
> > -#define CONFIG_SYS_NAND_U_BOOT_SIZE	0x32000
> > +#define CONFIG_SYS_NAND_U_BOOT_SIZE	0x40000
> >  /* Load U-Boot to this address */
> >  #define CONFIG_SYS_NAND_U_BOOT_DST	CONFIG_SYS_TEXT_BASE
> >  #define CONFIG_SYS_NAND_U_BOOT_START	CONFIG_SYS_NAND_U_BOOT_DST
> 
> Cool, then we need to determine the minimal change set required for v11, so
> can
> you retry with fewer of those changes to determine which ones are strictly
> necessary (apart from the watchdog removal that we already know is required)?

Especially, does it work with only:
-#define CONFIG_HW_WATCHDOG
-#define CONFIG_IMX_WATCHDOG
-#define CONFIG_SYS_NAND_U_BOOT_SIZE	0x32000
+#define CONFIG_SYS_NAND_U_BOOT_SIZE	0x3f800
?

> What is the size of u-boot-with-spl.bin without DEBUG?
> 
> Regarding the watchdog removal, it is unrelated to this patch, so do you want
> me
> to add a patch for it in this series, or will you handle it separately? And
> is
> the correct change to remove it as above, or to change its time-out
> somewhere? I
> think that it's probably better if you take care of this separately.

Best regards,
Benoît