[U-Boot] [PATCH 2/3] wandboard: Add support for carrier board MicroSD card

Otavio Salvador otavio at ossystems.com.br
Mon Apr 15 18:18:50 CEST 2013


On Mon, Apr 15, 2013 at 12:00 PM, Fabio Estevam <festevam at gmail.com> wrote:
> On Mon, Apr 15, 2013 at 11:06 AM, Otavio Salvador
> <otavio at ossystems.com.br> wrote:
>
>> Should we fail if *any* fail?
>
> Yes, I think so.

--- a/board/wandboard/wandboard.c
+++ b/board/wandboard/wandboard.c
@@ -162,13 +162,15 @@ int board_mmc_init(bd_t *bis)
                        gpio_direction_input(USDHC1_CD_GPIO);
                        break;
                default:
-                       printf("Warning: you configured more USDHC controllers"
+                       printf("ERROR: you configured more USDHC controllers"
                                   "(%d) than supported by the board\n", i + 1);
                        return -EINVAL;
                }

-               if (fsl_esdhc_initialize(bis, &usdhc_cfg[i]))
-                       printf("Warning: failed to initialize mmc dev %d\n", i);
+               if (fsl_esdhc_initialize(bis, &usdhc_cfg[i])) {
+                       printf("ERROR: failed to initialize mmc dev %d\n", i);
+                       return 1;
+               }
        }

Like this?

--
Otavio Salvador                             O.S. Systems
E-mail: otavio at ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br


More information about the U-Boot mailing list