[U-Boot] [PATCH 2/3] wandboard: Add support for carrier board MicroSD card

[Fabio Estevam]

On Mon, Apr 15, 2013 at 1:18 PM, Otavio Salvador
<otavio at ossystems.com.br> wrote:

> --- a/board/wandboard/wandboard.c
> +++ b/board/wandboard/wandboard.c
> @@ -162,13 +162,15 @@ int board_mmc_init(bd_t *bis)
>                         gpio_direction_input(USDHC1_CD_GPIO);
>                         break;
>                 default:
> -                       printf("Warning: you configured more USDHC controllers"
> +                       printf("ERROR: you configured more USDHC controllers"
>                                    "(%d) than supported by the board\n", i + 1);
>                         return -EINVAL;
>                 }
>
> -               if (fsl_esdhc_initialize(bis, &usdhc_cfg[i]))
> -                       printf("Warning: failed to initialize mmc dev %d\n", i);
> +               if (fsl_esdhc_initialize(bis, &usdhc_cfg[i])) {
> +                       printf("ERROR: failed to initialize mmc dev %d\n", i);
> +                       return 1;

1 is not an appropriate return value for an error.

What about doing like sabrelite?
status |= fsl_esdhc_initialize(bis, &usdhc_cfg[i]);

and then you return status?